Re: Patch: refresh parameter in get_folders forces a retrieve of folder structure

[Martin Bonnin <martinbonnin gmail com>]

Hello José,

   The patch is fine with me. Actually, our source code always calls
get_folders() with the refresh parameter set to "false" so there is no
chance we are impacted by this patch. That being said, I'm not sure if
the "cant_reuse_iter" optimization will be of big use now. We can play
it safe for now and keep it but I wonder if removing it and assume
true always would be that different in the end.

Best Regards,

--
Martin



> 2009/3/11 José Dapena Paz <jdapena igalia com>:
>>        Hi,
>>
>>        This patch just makes get_folders with refresh parameter enabled fetch
>> again the folder structure instead of using the cached one. This way we
>> can show also newly created folders.
>>
>>        This should make "refresh" operations slower (they'll always get again
>> the folder structure for remote accounts). It's good for most cases, as
>> we want to know the changes not only in the number of messages in
>> folders, but also in the folders available. Just, remember to review
>> your calls to get_folders, with refresh parameter.
>>
>>        If you have any, test the patch and tell us if you find problems.
>>
>>        In special, Rob, Mathew, please review this patch as you've introduced
>> the refresh api, so I guess you're users of this API :).
>>
>> --
>> José Dapena Paz <jdapena igalia com>
>> Igalia
>>
>> _______________________________________________
>> tinymail-devel-list mailing list
>> tinymail-devel-list gnome org
>> http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
>>
>>
>