Re: [PATCH 13/18] In pop3 provider, do a LIST before a folder sync

[Philip Van Hoof <spam pvanhoof be>]

On Tue, 2008-09-09 at 18:33 +0200, Sergio Villar Senin wrote:
> Rob Taylor escribiu:
> > In pop3 provider, do a LIST before a folder sync so failure doesnt
> > happen if wait_for_login_delay kills the store.
> 
> Could you explain a little bit why this is needed? I mean I don't
> understand why we need to force a connection in this case.

The if is not visible in the diff, it looks good to me.

You didn't see the if because it was not in the diff, or is there
something else Rob and me are missing, Sergio?


if (camel_disco_store_status (CAMEL_DISCO_STORE (pop3_store)) == CAMEL_DISCO_STORE_OFFLINE)
	return;

g_static_rec_mutex_lock (pop3_store->eng_lock);
if (pop3_store->engine == NULL) {
	camel_service_connect (CAMEL_SERVICE (pop3_store), ex);
	if (camel_exception_is_set (ex)) {
		g_static_rec_mutex_unlock (pop3_store->eng_lock);
		return;
	}
}


-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be