Re: Patch: avoid interlocks in let_idle_die

[Philip Van Hoof <spam pvanhoof be>]

Approved

On Sun, 2008-09-14 at 20:06 +0200, José Dapena Paz wrote:
> 	Hi,
> 
> 	This patch avoids some interlocks that can happen in the following
> situation:
> 	* In a thread, we wait for joining the idle thread, after locking the
> connect_lock (for example when we do a stop_idle in imap_command_start).
> 	* In the idle thread, let_idle_die stops trying to lock the
> connect_lock.
> 
> 	The cases I saw where this was happening were always when we tried to
> stop idle to do a new command after, and then, the let_idle_die is not
> that important. Then, I replaced the call to lock connect_lock with a
> trylock.
> 
> Changelog would be:
> * libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-store.c
>   (let_idle_die): do a trylock in connect_lock instead of lock, so that
>   we can avoid interlocks on stop_idle called from imap_command_start.
> 
> 
> _______________________________________________
> tinymail-devel-list mailing list
> tinymail-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be