Re: Patch: gtk folder store configurable with flags

[Philip Van Hoof <spam pvanhoof be>]

On Fri, 2008-11-21 at 18:38 +0100, José Dapena Paz wrote:
> El vie, 21-11-2008 a las 18:16 +0100, Philip Van Hoof escribió:
> > No patch, please attach it :)
> 
> 	Here it goes, now patch attached :).
> 
> > > 	This patch adds a new constructor for the gtk folder store, so that
> > > developer can pass some flags specifying the way the folder store will
> > > be filled.
> > > 
> > > 	I added two flags:
> > > 	* One makes folder names in treemodel contain the full path, instead of
> > > the name of the folder leaf.

This feature I agree with

> > > 	* The other one puts all the folders at the same tree level (put
> > > folders in a list, instead of a tree).

This feature I don't agree with. Instead, make a new component that you
don't call TnyGtkFolderStoreTreeModel, but TnyGtkFolderStoreListModel.


> > > 	Both can be combined to show a plain representation of all the folders.
> > > 
> > > Changelog would be:
> > > * libtinymailui-gtk/tny-gtk-folder-store-tree-model.[ch]:
> > > 	* Now developer can set flags on constructing the widget, to
> > > 	   specify how folders will be added to tree model.
> > > 	* One of the modes will make name column contain the full path
> > > 	  of a folder.
> > > 	* Another mode will store all the folders at the same level 
> > > 	  (show items as a list instead of as a tree).
> > > 
-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be