Re: Patch: fix the progress information when refreshing an imap folder

[Philip Van Hoof <spam pvanhoof be>]

On Thu, 2008-11-20 at 17:46 +0100, Sergio Villar Senin wrote:
> Martin Bonnin escribiu:
> > Actually, for the tny_folder_refresh_async() method, each time the
> > status code is TNY_FOLDER_STATUS_CODE_REFRESH. And the progress I get
> > is something like :
> > 
> > 235/18056
> > 684/18056
> > 1289/18056
> > 1220/1450
> > 1875/18056
> > 2150/18056
> > ...
> > 
> > So I do not see how to filter this "1450". I can of course make a "low
> > pass" filter that checks the last 3 out of last 4 progress but I would
> > rather expect tinymail to send me consistent progress information.
> 
> Martin tinymail currently does that, just check how we do it in Modest,
> you just need to ignore all those status data which are not tagged as
> that. In Modest we do it this way:
> 
> 	/* Show only the status information we want */
> 	if (status->code != TNY_FOLDER_STATUS_CODE_REFRESH)
> 		return;
> 
> And that's all. With this filter you'll only get progress information
> about the folder refresh and not about the other operations.
> 
> So, IMHO we should revert that change.

Ok, then let's revert those patches.

Martin, can you take care of reverting them?

-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be