Re: Patch: fix for imap_update_summary crash on AOL



Yeap, approved.

Very nice José, this is awesome stuff.

Let's test this thoroughly, though!

(With a lot of IMAP servers)


On Wed, 2008-07-16 at 13:16 +0200, José Dapena Paz wrote:
> 	Hi,
> 
> 	This patch adds a workaround for AOL IMAP server bug answering to
> FETCH/SEARCH queries we use to get the list of uid's. When we request a
> range of sequence numbers, the answer returns again all the sequences,
> even the ones we had fetched previoulsly.
> 
> 	With this code we simply ignore the sequence numbers we already have
> fetched. This is enough to avoid the summary corruption we were getting
> using AOL.
> 
> Changelog entry:
> * libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-store.[ch]:
>         * Added fetching aol specific imap capability.
> * libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-folder.[ch]:
>         * Now we use FETCH instead of SEARCH for getting the UID's
>           when the server is AOL.
>         * Added an extra check in imap_get_uids. If server gives a list
>           including sequence numbers we didn't request, we ignore them.
>           This should fix the AOL problem fetching headers.
> 
> 
> _______________________________________________
> tinymail-devel-list mailing list
> tinymail-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be






[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]