Patch to tny-maemo-conic-device



Hi,

I think there is a wrong condition in the on_connection_event method of
the maemo conic device. It provokes that when the user selects cancel in
the "Select connection" dialog then the user callback of
tny_maemo_conic_device_connect_async won't be called which is wrong.

Philip I think you implemented it although svn blames me :-) I don't see
the reason for that condition maybe some could

Br
Index: tny-maemo-conic-device.c
===================================================================
--- tny-maemo-conic-device.c	(revision 3261)
+++ tny-maemo-conic-device.c	(working copy)
@@ -310,11 +310,7 @@
 
 	priv->is_online = is_online;
 
-	if (priv->connect_slot && 
-		(con_err != CON_IC_CONNECTION_ERROR_NONE || 
-		 con_state == CON_IC_STATUS_CONNECTED)) 
-	{
-
+	if (priv->connect_slot)	{
 		/* If there's an error or if we just connected, we call the
 		 * callback for tny_maemo_conic_device_connect, if any */
 
@@ -324,7 +320,7 @@
 		iinfo->con_state = con_state;
 
 		g_idle_add_full (G_PRIORITY_HIGH, handle_con_idle, iinfo, 
-			handle_con_idle_destroy);
+				 handle_con_idle_destroy);
 	}
 
 	if (emit)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]