Re: [PATCH 11/18] Add tny_camel_send_queue_new_with_folders
- From: Philip Van Hoof <spam pvanhoof be>
- To: Rob Taylor <rob taylor codethink co uk>
- Cc: tinymail-devel-list <tinymail-devel-list gnome org>
- Subject: Re: [PATCH 11/18] Add tny_camel_send_queue_new_with_folders
- Date: Sun, 31 Aug 2008 21:56:04 +0200
On Sun, 2008-08-31 at 20:50 +0100, Rob Taylor wrote:
> Philip Van Hoof wrote:
> > Not approved, you are not first unreferencing priv->outbox_cache and
> > priv->sendbox_cache. Afaik is that a leak (the _init happens during the
> > g_object_new).
> >
> > Preferably we do this with a protected property in teh GObject instead
> > too. That way can people who subclass TnyCamelSendQueue mimic your new
> > constructor.
>
>
> Hmm, I'm confused... instance_init sets outbox_cache and sentbox_cache
> to NULL. The TnyFolder instances are created on the first call of
> get_outbox or get_sentbox.
>
> Have I misunderstood something?
In that case, approved
> Thanks,
> Rob
>
> >
> > On Fri, 2008-08-29 at 17:45 +0100, Rob Taylor wrote:
> >> Add tny_camel_send_queue_new_with_folders to create a TnyCamelSendQueue
> >> with user-created folders
> >>
> >> ---
> >> libtinymail-camel/tny-camel-send-queue.c | 24 ++++++++++++++++++++++++
> >> libtinymail-camel/tny-camel-send-queue.h | 2 ++
> >> 2 files changed, 26 insertions(+), 0 deletions(-)
> >
> >
>
>
--
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
http://pvanhoof.be/blog
http://codeminded.be
[
Date Prev][Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]