Re: [PATCH 11/18] Add tny_camel_send_queue_new_with_folders

[Philip Van Hoof <spam pvanhoof be>]

Not approved, you are not first unreferencing priv->outbox_cache and
priv->sendbox_cache. Afaik is that a leak (the _init happens during the
g_object_new).

Preferably we do this with a protected property in teh GObject instead
too. That way can people who subclass TnyCamelSendQueue mimic your new
constructor.


On Fri, 2008-08-29 at 17:45 +0100, Rob Taylor wrote:
> Add tny_camel_send_queue_new_with_folders to create a TnyCamelSendQueue 
> with user-created folders
> 
> ---
>   libtinymail-camel/tny-camel-send-queue.c |   24 ++++++++++++++++++++++++
>   libtinymail-camel/tny-camel-send-queue.h |    2 ++
>   2 files changed, 26 insertions(+), 0 deletions(-)


-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be