Re: new API proposal find_msg_async

[Philip Van Hoof <spam pvanhoof be>]

One problem remaining:

+#ifdef DBC /* require */
+	g_assert (TNY_IS_FOLDER (self));
+	g_assert (url_string);
+	g_assert (strlen (url_string) > 0);
+	g_assert (strstr (url_string, "://") != NULL);
+	g_assert (TNY_FOLDER_GET_IFACE (self)->get_msg_async!= NULL);
+#endif

I think the "://" assertion on url_string should be just ":", not "://",
else wont maildir url_strings be allowed.

Also move the tny_folder_find_msg API within the deprecated markers.


On Mon, 2008-04-28 at 14:51 +0200, José Dapena Paz wrote:
> El lun, 21-04-2008 a las 22:39 +0200, Philip Van Hoof escribió:
> > Hey Sergio!
> 
> 	I've been updating this patch following your recommendations. Attached
> to this mail is the new version of the find msg async support patch.
> 
> > 
> > Can you also move the original find_msg in the TNY_DISABLE_DEPRECATED
> > ifdef and add the deprecation marker in the gtk-doc comments?
> 
> 	Done. Also added proper gtk doc for find msg async.
> 
> > 
> > Unless necessary for Modest it was not required to create a new
> > TNY_FOLDER_STATUS_CODE_FIND_MSG. Reusing the status-code for GET_MSG was
> > sufficient for me (but you choose, maybe it's indeed better to be more
> > fine grained about this).
> 
> 	Removed the new code.
> 
> > 
> > I'm fine with reusing the GetMsg's info structure, but please add some
> > comments near the structure explaining that two async implementations
> > are using the structure. That way will a future developer be alarmed
> > when changing things here.
> 
> 	Now we don't reuse the structure.
> 
> > 
> > ! And now ...
> > 
> > Finally the blocker issue with your patch is that you didn't implement
> > it for TnyMergeFolder. Without that implementation of your new method, I
> > wont accept the patch. Of course.
> 
> 	 :) Implemented too.
> 
-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be