Re: new API proposal find_msg_async

[Philip Van Hoof <spam pvanhoof be>]

Hey Sergio!

Can you also move the original find_msg in the TNY_DISABLE_DEPRECATED
ifdef and add the deprecation marker in the gtk-doc comments?

Unless necessary for Modest it was not required to create a new
TNY_FOLDER_STATUS_CODE_FIND_MSG. Reusing the status-code for GET_MSG was
sufficient for me (but you choose, maybe it's indeed better to be more
fine grained about this).

I'm fine with reusing the GetMsg's info structure, but please add some
comments near the structure explaining that two async implementations
are using the structure. That way will a future developer be alarmed
when changing things here.

! And now ...

Finally the blocker issue with your patch is that you didn't implement
it for TnyMergeFolder. Without that implementation of your new method, I
wont accept the patch. Of course.



On Mon, 2008-04-21 at 19:31 +0200, Sergio Villar Senin wrote:
> Hi,
> 
> this is a proposal for a new API, tny_folder_find_msg_async which will
> make the sync version obsolete. I reused the sync version implementation
> for this async version. Most of methods could be shared with
> tny_camel_folder_get_msg_async but I decided not to use the same as long
> as it's not done in any other place in tinymail.
> 
> What I actually reused was the GetMsgInfo structure, so maybe we could
> decide to share some of the _destroy and _callback methods with get_msg
> 

-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be