Re: Fixing TnyCamelGetSupportedSecureAuthCallback error propagation.

[Philip Van Hoof <spam pvanhoof be>]

Approved, please commit

On Wed, 2007-09-05 at 09:56 +0200, Murray Cumming wrote:
> On Tue, 2007-09-04 at 20:16 +0200, Philip Van Hoof wrote:
> > On Tue, 2007-09-04 at 19:33 +0200, Murray Cumming wrote:
> > > -               if (callback)
> > > -                       callback (self, TRUE /* cancelled */, NULL,
> > > &err, user_data);
> > > -               g_error_free (err);
> > > +               if (callback) {
> > > +                       /* Note: The callback must free the GError if
> > > it is not NULL: */
> > > +                       callback (self, TRUE /* cancelled */, NULL,
> > > err, user_data);
> > > +               }
> > 
> > No, Tinymail must free this error once the callback is finished. Not the
> > callback.
> 
> Quite right. I was confusing myself. Here's an updated patch.
> 
-- 
Philip Van Hoof, software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://www.pvanhoof.be/blog