Re: Fixing TnyCamelGetSupportedSecureAuthCallback error propagation.
- From: Philip Van Hoof <spam pvanhoof be>
- To: Murray Cumming <murrayc murrayc com>
- Cc: tinymail-devel-list <tinymail-devel-list gnome org>
- Subject: Re: Fixing TnyCamelGetSupportedSecureAuthCallback error propagation.
- Date: Tue, 04 Sep 2007 20:16:37 +0200
On Tue, 2007-09-04 at 19:33 +0200, Murray Cumming wrote:
> - if (callback)
> - callback (self, TRUE /* cancelled */, NULL,
> &err, user_data);
> - g_error_free (err);
> + if (callback) {
> + /* Note: The callback must free the GError if
> it is not NULL: */
> + callback (self, TRUE /* cancelled */, NULL,
> err, user_data);
> + }
No, Tinymail must free this error once the callback is finished. Not the
callback.
--
Philip Van Hoof, software developer
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
http://www.pvanhoof.be/blog
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]