Re: Connecting and account management
- From: Philip Van Hoof <spam pvanhoof be>
- To: Sergio Villar Senin <svillar igalia com>
- Cc: tinymail-devel-list gnome org
- Subject: Re: Connecting and account management
- Date: Fri, 27 Jul 2007 12:06:50 +0200
On Fri, 2007-07-27 at 11:14 +0200, Sergio Villar Senin wrote:
> Philip Van Hoof wrote:
>
>
> > * Hoping that a lot people will review this larger patch *
>
> A few comments:
>
> * why using the account id to do the hashing in the hash table, we can
> not be sure that there are not two accounts with the same id.
Actually you are sure about that: it's hard specified that the account
id must be unique.
> * you removed almost all the account store signals. Why? I mean, the
> addition or removal of accounts has nothing to do with connection statuses.
Because tinymail does not issue them. The application developer can
still add them to his own implementation or type.
--
Philip Van Hoof, software developer
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
http://www.pvanhoof.be/blog
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]