Re: Connecting and account management



Philip Van Hoof wrote:


> * Hoping that a lot people will review this larger patch *

A few comments:

* why using the account id to do the hashing in the hash table, we can
not be sure that there are not two accounts with the same id.

* you removed almost all the account store signals. Why? I mean, the
addition or removal of accounts has nothing to do with connection statuses.

Br



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]