Re: Patch for reducing problems with getaddrinfo calls.

[Philip Van Hoof <spam pvanhoof be>]

Approved

On Mon, 2007-07-23 at 11:58 +0200, Jose Dapena Paz wrote:
> 	Hi,
> 
> 	As Philip suggested, I've been working last week in a separate branch.
> There are four patches in that branch. First two where already sent to
> the mailing list.
> 
> 	This mail is for the approval of the third patch. It reduces the
> problems with blockings for using addrinfo, as it caches the addrinfo
> information obtained in camel imap folder. It also includes some locking
> changes. It's in the 2478 commit. The changelog:
> 
> * libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-folder.c:
> (imap_refresh_info): now we lock the folder also, before locking the
> service, in order to respect better the lock order. This should avoid
> some locks.
> 
> *libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-store.[ch]:
> now we store a reference to the struct addrinfo used for connections.
> When we are successful getting a valid addrinfo, it's stored and reused.
> This way we prevent doing lots of calls to getaddrinfo and subsequent
> name resolutions. As we're currently blocking while name resolution is
> running, this should make the application more reponsive in general and
> avoid flooding the connection. We also removed the method
> (camel_imap_service_connect) as it's not used.
> 
> * libtinymail-camel/camel-lite/camel/camel-private.h:
> added parenthesis to some lock macros.
> 
> _______________________________________________
> tinymail-devel-list mailing list
> tinymail-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
-- 
Philip Van Hoof, software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://www.pvanhoof.be/blog