Re: Renaming a folder while the connection dissapears

[Philip Van Hoof <spam pvanhoof be>]

Note that this only works since after the blocked-read/write patch:

http://tinymail.org/trac/tinymail/changeset/2349

Before that, the thread doing this would just hang (forever) and block
waiting for the read or write to finish.

On Mon, 2007-07-02 at 20:24 +0200, Philip Van Hoof wrote:
> The test was renaming a folder while the connection is broken.
> 
> I was surprised to see the "recurse copy" and "create" to still happen,
> even though Tinymail has detected that we're offline at that moment.
> 
> Somebody should review the error handling in recurse_copy in
> tny-camel-folder.c. Maybe, though, it's just "retries" and the debugging
> line being printed very early. The end result was okay, by the way. No
> folder got moved or copied. Locally nothing "too much" happened either:
> 
> pvanhoof schtrumpf:~/repos/tinymail/trunk$ ls /home/pvanhoof/.tinymail/mail/imap/10.84.78.89/folders/INBOX/subfolders/
> 100  1000
> pvanhoof schtrumpf:~/repos/tinymail/trunk$ 
> 
> I marked the lines that surprised me with "-->" 's
> 
> I added Sergio in CC because he worked with me on the implementation.
> 
> 
> camel_imap_folder_start_idle
> (.., ..) -> B00013 IDLE | in idle_real_start
> (.., ..) <- + idling | in idle_real_start
> idle_thread
> idle_thread starting (B00013)
> idle_deal_with_stuff
> (6, 8) -> DONE | Sending DONE in idle_deal_with_stuff (nb)
> (.., ..) -> B00014 IDLE | in idle_real_start
> (.., ..) <- + idling | in idle_real_start
> idle checked in idle_thread, waiting 20s for new check
> tny_folder_copy: rename INBOX/100 to INBOX/100b
> Sending DONE in camel_imap_store_stop_idle (no current folder?)
> (21, 21) -> B00015 SELECT INBOX
> 
> imap_disconnect_online
> imap_disconnect_offline
> TNY_DEBUG: Local test disconnected 
> --> tny_folder_copy: recurse_copy
> --> tny_folder_copy: create 100b
> imap_connect_online
> TNY_DEBUG: Local test failed connecting 
> CON EVENT FOR Local test: con broken
> CON EVENT FOR Local test: con broken
> 
> pvanhoof schtrumpf:~/repos/tinymail/trunk$
> 
-- 
Philip Van Hoof, software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://www.pvanhoof.be/blog