Re: Some bugs found when compiling for maemo

[Philip Van Hoof <spam pvanhoof be>]

On Sat, 2007-02-10 at 18:13 +0200, Tomi Pievil�en wrote:
> Hi,
> 
> Found the following small bugs when compiling tinymail for maemo:
> 
> Index: libtinymail-camel/camel-lite/libedataserver/e-iconv.c
> ===================================================================
> --- libtinymail-camel/camel-lite/libedataserver/e-iconv.c   (revision 1558)
> +++ libtinymail-camel/camel-lite/libedataserver/e-iconv.c   (working copy)
> @@ -381,7 +381,7 @@
>         
>         if (iso == 10646) {
>             /* they all become ICONV_10646 */
> -           ret = g_strdup (ICONV_10646);
> +           ret = g_strdup ("ICONV_10646");


Euh, no. That define should have been set in iconv-detect.h which is
generated during the ./configure 


>         } else {
>             tmp = p;
>             if (*tmp == '-' || *tmp == '_')
> 
> Index: libtinymail-camel/camel-lite/camel/camel-tcp-stream-openssl.c
> ===================================================================
> --- libtinymail-camel/camel-lite/camel/camel-tcp-stream-openssl.c   (revision 1558)
> +++ libtinymail-camel/camel-lite/camel/camel-tcp-stream-openssl.c   (working copy)
> @@ -369,7 +369,6 @@
>                     nread = read (openssl->priv->sockfd, buffer, n);
>                 }
>               } while (0 && (nread < 0 && errno == EINTR));
> -           }

For this one I think you are using an older file in the repository (this
was fixed yesterday).



>         } while (0 && (nread < 0 && (errno == EAGAIN || errno == EWOULDBLOCK)));
>         
>         error = errno;
> 
> _______________________________________________
> tinymail-devel-list mailing list
> tinymail-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
-- 
Philip Van Hoof, software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://www.pvanhoof.be/blog