Re: No panic, I just merged some stuff

[Philip Van Hoof <spam pvanhoof be>]

On Wed, 2007-12-05 at 22:23 +0100, Philip Van Hoof wrote:
> And it's --enable-imap-part-fetch now to enable it ... (I know Dave
> wants to try this stuff, so I added him in CC :p).
> 
> This works with modest too (just tested it), although Modest wont do
> status reporting when retrieving the individual parts (the UI will hang
> until fully received each time it needs to fetch a part).
> 
> This can easily be fixed, of course (just use tny_mime_part_decode_
> to_stream_async in stead of the non-async one, and pass your
> status-callback and user_data for it in the parameters of that
> function).
> 
> However, I don't think this feature will be shipped with Modest's first.

Note before the panic starts: this is a test on a device with the new
feature, that is per default "disabled", "enabled". This is NOT the
default (the defaults don't do any harm whatsoever).

Regretfully will Modest decode each and every part for some reason (no
matter what). So this means it fetches all parts once you open the mail
in the mail viewer anyway ;-)

Of course this ain't necessary, and sounds highly inefficient too, so
for now to use this feature is a bit pointless with Modest.

I also noticed that tapping on images doesn't make any action happen nor
is in the menu "Attachment" anything undimmed. I guess it's checking for
something before doing the action (streaming the content to a location
and then opening that location in the image viewer of the device, for
example).



> On Wed, 2007-12-05 at 21:55 +0100, Philip Van Hoof wrote:
> > Tonight's merge is nothing to panic about. I just merged the bodystruct
> > branch to trunk.
> > 
> > However, this (new) code is disabled by not setting the receive-msg
> > strategy that ignites it all in the IMAP-folder implementation of
> > Tinymail.
> > 
> > The magic key to enable it can be found here:
> > 
> > static void
> > tny_camel_imap_folder_instance_init (GTypeInstance *instance, gpointer g_class)
> > {
> >         TnyCamelFolderPriv *priv = TNY_CAMEL_FOLDER_GET_PRIVATE (instance);
> > 
> > /* Disabled until after the first release
> >         if (priv->receive_strat)
> >                 g_object_unref (priv->receive_strat);
> > 
> >         priv->receive_strat = tny_camel_bs_msg_receive_strategy_new ();
> > */                                      ^
> >                                         |
> > ----------------------------------------'
> >         return;
> > }
> > 
> > I will most likely make a --enable-something for Tinymail's 1.0. By
> > default this wont be enabled in Tinymail 1.0, though.
> > 
> > No significant API changes occurred. I tested all related operations
> > with today's Modest. Nothing existing got influenced by this.
> > 
> > 
> > 
-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be