Re: Patch that adds some API to the merge folder

[Philip Van Hoof <spam pvanhoof be>]

Looks good. Please commit

On Fri, 2007-08-31 at 14:32 +0200, Sergio Villar Senin wrote:
> Philip Van Hoof wrote:
> > On Fri, 2007-08-31 at 12:51 +0200, Sergio Villar Senin wrote:
> >> Philip Van Hoof wrote:
> >>> On Fri, 2007-08-31 at 12:10 +0200, Sergio Villar Senin wrote:
> >>>
> >>>> I'd like to add two new functions to the TnyMergeFolder API. These two
> >>>> ones are:
> >>>>
> >>>> void tny_merge_folder_remove_folder (TnyMergeFolder *self, TnyFolder
> >>>> folder);
> >>> This one sounds good
> >>>
> >>>> gint tny_merge_folder_get_num_folders (TnyMergeFolder *self);
> >>> Either this and change tny_list_get_length to tny_list_get_num_items or
> >>> change this to tny_merge_folder_get_length or something. This feels a
> >>> little bit inconsistent in my opinion :-\
> >> Sure, I was not very happy with the name. I was doubting between adding
> >> this function or another one that just returns the list of folders, but
> >> maybe we do not want to expose too much that list, not sure.
> > 
> > I would do that, indeed. Why not? The app developer had to add the
> > items, so why not allow him to get them too?
> 
> Second version of the patch with Philip's suggestions
> 
> Br
> 
> _______________________________________________
> tinymail-devel-list mailing list
> tinymail-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
-- 
Philip Van Hoof, software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://www.pvanhoof.be/blog