Re: CamelUrl: :/ or ://

[Philip Van Hoof <spam pvanhoof be>]

Hey Murray,

Indeed, it looks like a kludge or a mess-up to me. I'll take a look at
this today or tomorrow and try to normalise this on ://. I'll also
search in the code why there's atm one :/ and why that also seems to
work (if it does).

Thanks for reporting.


On Thu, 2007-08-16 at 20:03 +0200, Murray Cumming wrote:
> On Thu, 2007-08-16 at 19:29 +0200, Murray Cumming wrote:
> > I noticed that camel_url_to_string() returns, for instance, 
> > "maildir:/home/murrayc/.modest/yaddayadda"
> > when we create a "maildir:" CamelUrl, but 
> > "imap://myaccount/myfolder/yaddayadda"
> > when we create an "imap:" CamelUrl"
> 
> Actually, I'm wrong. camel_url_to_string() actually returns, for
> instance,
> maildir://localhost/home/murrayc/.modest/yaddayadda
> 
> And the problem is that we are trying to use a URI that we built from 
> tny_folder_get_url_string(), but that doesn't include the "/localhost"
> part, instead giving:
> "maildir:/home/murrayc/.modest/yaddayadda"
> 
> I've looked in tinymail and camel-lite but I can't yet figure out what
> part of the code is building that URI.
> 
> > So that's one / for maildir, but two for imap and pop. 
> > 
> > As an additional clue, the CamelURL documentation says that it would
> > create a file:// prefix from a file: CamelUrl:
> > http://www.go-evolution.org/Camel.URL#Example:_Creating_a_file_URL
> > 
> > Does the maildir: URL seem wrong to you too, or can you think of a
> > reason? I doubt it's meant to be a real well-formed URL, but the
> > inconsistency is odd.
> > 
> > I noticed it because we are checking the validity of these URLs in
> > modest and currently checking for two /s.
> 
> Also, the assertion check is in tinymail itself, and only when building
> with the DBC checks.
>  
-- 
Philip Van Hoof, software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://www.pvanhoof.be/blog