Re: [Fwd: Issue creating folders]

[Sergio Villar Senin <svillar igalia com>]

Philip Van Hoof wrote:
> On Tue, 2007-04-24 at 20:32 +0200, Philip Van Hoof wrote:
>> ps. It looks like Sergio is right
>>
>> email message attachment, "Forwarded message - Issue creating folders"
>>> -------- Forwarded Message --------
>>> From: Sergio <quiniela_rnasa yahoo es>
>>> To: tinymail-devel-list gnome org
>>> Subject: Issue creating folders
>>> Date: Tue, 24 Apr 2007 20:16:56 +0200
>>>
>>> Hi,
>>>
>>> I was trying to create a folder in an IMAP folder with the server
>>> stopped. Then I got an abort(). Looking at the code the abort is located
>>> in tny-camel-folder.c:2496.
>>>
>>> The problem is that the condition that the assert checks could happen in
>>> this situation. Looking at the create_folder method of the IMAP provider
>>> it returns NULL when the store is not online, so I think we should
>>> manage this case in a better way.
> 
> 
> Aha, but this also means that no folder will be created. So it's
> basically an error situation that should trigger setting "ex" to
> something that is a camel error.

Right. It'd be nice to have this fixed.

> if (!camel_disco_store_check_online (CAMEL_DISCO_STORE (store), ex))
> 		return NULL;
> 
> 
> Something like: you are offline, I can't create this folder.

Agree.

> I know offline moving messages around is possible. I don't think offline
> creating folders is. I haven't in-depth checked this in Camel's provider
> code though.

I don't know either.

Br

PS: I made a mistake sending the mail from another account, seems that
you inferred that it was mine, well done Philip :)