Double lock issue, when trying to remove a file

[Sergio Villar Senin <svillar igalia com>]

Hi,

the remove strategy has a double lock issue when trying to delete a
message. This is the sequence

tny_camel_folder_remove_msg_default ()
{
[...]
g_mutex_lock(priv->folder_lock);
[...]
tny_msg_remove_strategy_remove (...)

and then inside this call we have a tny_camel_folder_get_folder that
will call g_mutex_lock again.

My suggestion will be to create a "protected" method in tny_camel_folder
called for example tny_camel_folger_get_folder_no_lock that will perform
the same operation but without locking.

Opinions?

Br