Some bugfixes
- From: Sergio Villar Senin <svillar igalia com>
- To: tinymail-devel-list gnome org
- Subject: Some bugfixes
- Date: Thu, 14 Dec 2006 13:08:39 +0100
Hi,
find attached a patch that fixes an issue when copying GErrors in the
asynchronous methods of TnyCamelFolder. It also sets as NULL a GError
that were used erroneously without initialization.
Br
Index: libtinymail-camel/tny-camel-folder.c
===================================================================
--- libtinymail-camel/tny-camel-folder.c (revision 1317)
+++ libtinymail-camel/tny-camel-folder.c (working copy)
@@ -719,7 +719,7 @@
TNY_FOLDER_ERROR_REFRESH,
camel_exception_get_description (&ex));
if (err != NULL)
- info->err = g_error_copy ((const GError *) &err);
+ info->err = g_error_copy ((const GError *) err);
}
priv->cached_length = camel_folder_get_message_count (priv->folder);
@@ -967,7 +967,7 @@
if (err != NULL)
{
- info->err = g_error_copy ((const GError *) &err);
+ info->err = g_error_copy ((const GError *) err);
if (info->msg && G_IS_OBJECT (info->msg))
g_object_unref (G_OBJECT (info->msg));
info->msg = NULL;
@@ -1419,7 +1419,7 @@
info->delete_originals, &err);
if (err != NULL)
- info->err = g_error_copy ((const GError *) &err);
+ info->err = g_error_copy ((const GError *) err);
else
info->err = NULL;
@@ -2015,7 +2015,7 @@
info->list, info->query, &err);
if (err != NULL)
- info->err = g_error_copy ((const GError *) &err);
+ info->err = g_error_copy ((const GError *) err);
else
info->err = NULL;
Index: libtinymail-camel/tny-camel-store-account.c
===================================================================
--- libtinymail-camel/tny-camel-store-account.c (revision 1317)
+++ libtinymail-camel/tny-camel-store-account.c (working copy)
@@ -570,7 +570,7 @@
tny_camel_store_account_get_folders_async_thread (gpointer thr_user_data)
{
GetFoldersInfo *info = (GetFoldersInfo*) thr_user_data;
- GError *err;
+ GError *err = NULL;
tny_folder_store_get_folders (TNY_FOLDER_STORE (info->self),
info->list, info->query, &err);
Index: ChangeLog
===================================================================
--- ChangeLog (revision 1317)
+++ ChangeLog (working copy)
@@ -1,3 +1,10 @@
+2006-12-14 Sergio Villar Senin <svillar igalia com>
+
+ * libtinymail-camel/tny-camel-folder.c: replaced some double pointers
+ by simple pointers
+ * libtinymail-camel/tny-camel-store-account.c: fixed a warning caused
+ by an uninitialized GError
+
2006-12-11 Sergio Villar Senin <svillar igalia com>
* libtinymail/tny-folder.h: added the tny_folder_get_msg_async
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]