RE: The iterator interface
- From: Philip Van Hoof <spam pvanhoof be>
- To: Dirk-Jan Binnema nokia com
- Cc: tinymail-devel-list gnome org
- Subject: RE: The iterator interface
- Date: Sat, 12 Aug 2006 13:03:19 +0200
On Wed, 2006-08-09 at 13:05 +0300, Dirk-Jan Binnema nokia com wrote:
> This is what I did in the patch I sent you. I have implemented
> it just as you wanted, and did not include any of my proposals.
Right. But there's multiple problems with the patch. I've send you a
E-mail about it.
I.e three iterators haven't been adapted tot he new API.
> The patch I sent should fix the thread-safety issues as well.
But makes the unit test not compile anymore. Not good :-), this at least
means that it wasn't tested code.
Not only should it compile, it should be fixed and working (doing
exactly the same as before the changes, and test whether the type being
tested still works).
You should also test every iterator-type (that can be instantiated)
using the same unit test.
Philip Van Hoof, software developer at x-tend
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
work: vanhoof at x-tend dot be
http://www.pvanhoof.be - http://www.x-tend.be
] [Thread Prev