See attached patch
On Mo, Jan 13, 2020 at 16:04, Jens Georg <mail jensge org> wrote:Also, regarding enforcing the timeout, I think it might be easier to port the thumbnailer to GSubprocess and use that to wait/kill the process. it has proper abstraction
On Mo, Jan 6, 2020 at 15:57, Christian Simon <csimon wesim de> wrote:Wow, I did't expect to receive that much feedback. Thanks a lot! I'll do my best to follow your advice.
It's good to know that the commits of the 0.30.8 release are there. Nowdays, one must invoke git-push with the "--tags" flag in order push the tags as well. Maybe, they forgot about that ...
Forgot one answer: As for your efforts to read the data from the video thumbnailer, at some point I'd rather have the thumbnailer write the thumbnail file directly to disk instead of passing it back via stdout.You're absolutely right. I wanted to keep my modifications as little invasive as possible. However, I completely forgot about the 10 seconds timeout enforcement. I'm evaluating different options at the moment. But it seems as though I will need to write a powershell script for enforcing the timeout and the nice level. And then, I would also have to dump the generated png to a temporary file. However, Windows powershell scripts are not for the weak of heart ...
On Mo, Jan 6, 2020 at 11:08, Jens Georg <mail jensge org> wrote:
Very nice. Scrolled through some of your commits, I think I can answer a couple of your "why" comments.
I do not now how GNOME's github mirror is working tbh. Interesting. the commit is there, but the tags aren't.
Btw. GNOME's gitlab has a win32 CI builder, which might be helpful.
On So, Jan 5, 2020 at 19:10, Christian Simon <csimon wesim de> wrote:
Great news, thanks! A few weeks ago, I forked the Shotwell repository on Github with the purpose to make Shotwell 0.30.7. compile and work on Windows with the Mingw compiler: https://github.com/cwrsimon/shotwell I think, I have made good progress so far. Most features seem to work. Now, I would like to test my code changes with the new 0.30.8 release. However, I cannot find the release tag in the Github repository, only in the Gitlab repository at https://gitlab.gnome.org/GNOME/shotwell. Do these two repositories only get synced at certain intervals? Best and thanks in advance, Christian Am 03.01.2020 um 19:37 schrieb Jens Georg:-------- Forwarded Message -------- From: Jens Georg <install-module master gnome org> Reply-To: desktop-devel-list gnome org To: FTP Releases <ftp-release-list gnome org> Subject: shotwell 0.30.8 Date: Fri, 3 Jan 2020 18:27:17 +0000 (UTC) About shotwell ============== Shotwell is a digital photo manager designed for the GNOME desktop environment. It allows you to import photos from disk or camera, organize them by keywords and events, view them in full-window or fullscreen mode, and share them with others via social networking and more. News ==== * Fix keyboard shortcut for adding tags * Fix Tumblr publishing * Fix month name translation in date/time chooser Bugs fixed in this release: - https://gitlab.gnome.org/GNOME/shotwell/issues/166 - https://gitlab.gnome.org/GNOME/shotwell/issues/196 All contributors to this release: - Jens Georg <mail jensge org> - Asier Sarasua Garmendia <asier sarasua gmail com> - Ryuta Fujii <translation sicklylife jp> - Daniel Mustieles <daniel mustieles gmail com> - Marek Černocký <marek manet cz> Added/updated translations: - cs.po, courtesy of Marek Černocký - es.po, courtesy of Daniel Mustieles - cs.po, courtesy of Marek Černocký - eu.po, courtesy of Asier Sarasua Garmendia - ja.po, courtesy of sicklylife Download ======== https://download.gnome.org/sources/shotwell/0.30/shotwell-0.30.8.tar.xz (6.16M) sha256sum: 722d2ed2ffc843b150490d5e346395398b0b5f40dd706034fa3a70f30e00f5b8 _______________________________________________ shotwell-list mailing list shotwell-list gnome org https://mail.gnome.org/mailman/listinfo/shotwell-list_______________________________________________ shotwell-list mailing list shotwell-list gnome org https://mail.gnome.org/mailman/listinfo/shotwell-list
_______________________________________________ shotwell-list mailing list shotwell-list gnome org https://mail.gnome.org/mailman/listinfo/shotwell-list