Re: Gnome Python 3 Goal

[Stef Walter <stefw gnome org>]

On 23.02.2013 20:38, Russ Adams wrote:
> Hello,
>
> I'm new around here, but use seahorse regularly for tracking my numerous
> passwords.
>
> I was poking around the GNOME goals list at
> (https://live.gnome.org/GnomeGoals/Python3Porting) and saw that seahorse
> was marked as 'to do' for Python 3 porting.  I noticed that the only
> Python-related code visible is in the 'tests' directory of the seahorse
> and libcryptui source trees.
>
> After a bit of research, it looks like these test scripts exercise the
> DBUS interface provided seahorse-daemon which has been moved to
> libcryptui. Can these tests live in only the libcryptui source tree or
> do they need to remain in both the seahorse and libcryptui trees?

Good catch. I've removed them from the seahorse tree.

> I've attached a trivial patch to port these scripts to Python 3.  I can
> vouch that these changes allow the scripts to pass Python 3's syntax
> checker.

Thank you for doing this work.

Do the scripts actually work at all though? I couldn't get them to work
as is. I noticed that dbus-python (ie: import dbus) isn't supported on
python3. I see comments about this here and there. For example:

https://bugzilla.redhat.com/show_bug.cgi?id=538616#c15

So this means that we would need to port the scripts to gdbus. But is
that really required by the GNOME goal? I didn't realize building and
testing infrastructure was in scope of the goal.

Cheers,

Stef