Re: seahorse distcheck broken

[Adam Schreiber <sadam clemson edu>]

On Tue, Feb 3, 2009 at 4:48 PM, Stef <stef-list memberwebs com> wrote:
> Sorry for the delay in the release. I've had a few bits of time here and
> there, and each time I try to roll a release with 'make distcheck' I get
> the following:
>
> mkdir /data/projects/seahorse/seahorse-2.25.90/reference/libcryptui/html
> cp ./tmpl/*.sgml
> /data/projects/seahorse/seahorse-2.25.90/reference/libcryptui/tmpl
> cp: cannot stat `./tmpl/*.sgml': No such file or directory
> make[3]: [dist-hook] Error 1 (ignored)
> cp ./xml/*.xml
> /data/projects/seahorse/seahorse-2.25.90/reference/libcryptui/xml
> cp: cannot stat `./xml/*.xml': No such file or directory
> make[3]: [dist-hook] Error 1 (ignored)
> cp ./html/*
> /data/projects/seahorse/seahorse-2.25.90/reference/libcryptui/html
> cp: cannot stat `./html/*': No such file or directory
> make[3]: *** [dist-hook] Error 1
> make[3]: Leaving directory `/data/projects/seahorse/reference/libcryptui'
> make[2]: *** [distdir] Error 2
> make[2]: Leaving directory `/data/projects/seahorse/reference/libcryptui'
> make[1]: *** [distdir] Error 1
> make[1]: Leaving directory `/data/projects/seahorse/reference'
> make: *** [distdir] Error 1
>
> Any ideas? I believe this was committed by you Adam.
>
> 2009-02-01  Adam Schreiber  <sadam clemson edu>
>
>    * autogen.sh:
>    * libcryptui/cryptui.c:
>    * configure.in:
>    * reference/libcryptui/libcryptui-overrides.txt: (added)
>    * reference/libcryptui/version.xml.in: (added)
>    * reference/libcryptui/Makefile.am: (added)
>    * reference/libcryptui/libcryptui-docs.sgml: (added)
>    * reference/Makefile.am:
>    * Makefile.am: Add infrastructure to add gtk-doc for libcryptui.
>    Removes block for bug #353061
>
> Sorry for laming out and asking for you to fix it, but time is really
> tight for me this week. Could you look into it?

distcheck isn't so much broken as adding gtk-doc to a source tree
requires adding the --enable-gtk-doc switch for distcheck to pass.

I've discovered in making releases that there's an error on the l.g.o
maintainers guide.  The instructions say to run ./autogen.sh && make
&& make install & make distcheck but it should really say ./autogen.sh
&& make & make distcheck.  Now with gtk-doc included our procedure
needs to be ./autogen.sh --enable-gtk-doc && make & make distcheck.

Cheers,

Adam

PS: Can you take a look at the libcryptui/DBus regressions that break
all key/signer selection functionality in seahorse-plugins.  I'm doing
a presentation on seahorse tonight at a LUG meeting and have had to
install seahorse-daemon from 2.24.x and seahorse and seahorse plugins
from trunk to make things work.