Re: Themes for 3.0

[Christopher Roy Bratusek <nano tuxfamily org>]

On Thursday 10 February 2011 18:36:51 fuchur wrote:
> Hi,
> 
> On Thu, 10 Feb 2011 18:11:28 +0100
> 
> wrote Christopher Roy Bratusek <nano tuxfamily org>:
> >> >  (= raise-window) to default tabbar keymap
> >> 
> >> That should be done by the "focus-in-hook" in tabgroup if window is
> >> tabbed. Then we always raise the window/tabgroup twice if window is
> >> tabbed. Why we need this by a single tab?
> >
> >Well I know what you mean, but: if one has focus-mode 'click, one would
> >not expect raise-tabs-on-hover, so we need t an "ordinary" way. On the
> >other hand, also people using 'enter-* modes may be fine with it.
> >
> >So the keybinding is here to fill the gap. I know that it may turn out as
> >sub- optimal... maybe you can come up with a better solution for this?
> 
> Maybe you bind the Button1-Off keymap to something like this:
> if/or/and/not raise-tabs-on-hover (focus-mode xxx) raise w ?

Of course... (why didn't I have the idea?)

(even if you use enter-* you may have configured Sawfish to not auto-raise, thus 
we leave this solely to tab-raise-on-hover)

diff --git a/lisp/sawfish/wm/keymaps.jl b/lisp/sawfish/wm/keymaps.jl
index 959e557..67bcd01 100644
--- a/lisp/sawfish/wm/keymaps.jl
+++ b/lisp/sawfish/wm/keymaps.jl
@@ -126,6 +126,10 @@
     :type keymap)
 
   (defcustom tabbar-keymap (bind-keys (make-keymap)
+				      "Button1-Off" (lambda ()
+						      (require 'sawfish.wm.tabs.tabgroup)
+						      (unless tab-raise-on-hover
+							(tab-refresh-group (current-event-window) 
'raise)))
 				      "Button1-Off2" 'toggle-window-shaded
 				      "Button1-Move" 'move-window-interactively
 				      "C-Button1-Off" 'tab-add-to-group