Re: [PATCH] librep: dlmalloc is unused



Am Wed, 6 Jan 2010 19:15:54 +0200
schrieb "Kim B. Heino" <b bbbs net>:

> > As long as you are doing this, could you also look into removing the
> > stack direction growth checks? As far as I can see, they are only
> > used by dlmalloc.c,
> 
> Stack direction check and STACK_DIRECTION define is used by alloca.c
> and continuations.c.
> 
> alloca.c is not needed with modern glibc or uClibc. Should I create a
> patch to delete it?

Which version is modern? Anything that would break Debian 5.0 is not to
be commited. (RedHat/CentOS are already (missing GTK+ 2.12) but they're
even `older' than Debian Lenny)

> continuations and multi-threading is enabled by default, so stack
> growth direction check can't be deleted.
> 
> There's also memcmp.c. I think we could delete that one too.

I guess, too, as memcmp is also part of libc.

Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]