Re: [PATCH] cycle-class don't ignore window-order

[Teika Kazura <teika lavabit com>]

Hi. I doubt the following patch.

On Thu, 26 Nov 2009 20:45:37 +0100, Christopher Roy Bratusek wrote:
> diff --git a/lisp/sawfish/wm/commands/x-cycle.jl
> b/lisp/sawfish/wm/commands/x-cycle.jl index 71afc85..1d6c247 100644
> [...]
>                         (filter-windows
> -                        (lambda (x) (equal (window-class x) class))))))
> +                        (lambda (x) (equal (window-class x) class))
> +                        (window-order)))))
>      #:spec "%W")

The current code looks:
------------------------------------------------------------------------
(define-cycle-command-pair
  'cycle-class 'cycle-class-backwards
  (lambda (w)
    (let ((class (window-class w)))
      (delete-if-not window-in-cycle-p
                     (filter-windows
                      (lambda (x) (equal (window-class x) class))
                      (window-order)))))
------------------------------------------------------------------------
'define-cycle-command-pair' expects that the list of windows to be
cycled returned. So the original looks ok. What was the intention?

Furthermore, filter-windows takes only one argument, so (window-order)
is ignored in fact. So it's harmless at least, but not a bugfix either.

Regards,
Teika (Teika kazura)