Re: [PATCH] sawfish: spec file update for KDE

[Christopher Roy Bratusek <zanghar freenet de>]

Am Sun, 3 Jan 2010 11:01:03 -0700
schrieb Michal Jaegermann <michal harddata com>:

> On Sun, Jan 03, 2010 at 06:02:58PM +0100, Christopher Roy Bratusek
> wrote:
> > Am Sun, 3 Jan 2010 09:53:44 -0700
> > schrieb Michal Jaegermann <michal harddata com>:
> > 
> > > On Sun, Jan 03, 2010 at 02:50:06PM +0200, Kim B. Heino wrote:
> > > > This patch uses %{_kde4_appsdir} macro instead of `kde4-config
> > > > --install data`. If it is missing we fallback to
> > > > %{_datadir}/kde4/apps.
> > > 
> > > I still think that you would need to modify %files section
> > > accordingly.
> ....
> > 
> > On the other hand one might ask, why we install the gnome
> > sawfish.desktop file, regardless wether GNOME is installed or not.
> 
> Regardless one should end up with
> 
> %{kde_apps}/ksmserver/windowmanagers/sawfish.desktop

^^^^^^^^^^^^^^^^^^^^^^^^

It is in 1.6.1 HEAD

> line in %files section and between all these flying patches I do no
> think it is there.
> 
> The difference we were talking about was not between GNOME and KDE
> but between KDE4 and earlier KDE.  I was rather worried about an
> installation process than an extra file.  Both missing or
> unaccounted for files generate errors in an rpm packaging.  I do not
> have now a setup where the current sawfish still compiles and only
> KDE3 is present so I cannot check what happens in such situation.
> 
>    Michal