Re: [PATCH] sawfish: spec file update for KDE

[Christopher Roy Bratusek <zanghar freenet de>]

Am Sun, 3 Jan 2010 09:53:44 -0700
schrieb Michal Jaegermann <michal harddata com>:

> On Sun, Jan 03, 2010 at 02:50:06PM +0200, Kim B. Heino wrote:
> > This patch uses %{_kde4_appsdir} macro instead of `kde4-config
> > --install data`. If it is missing we fallback to
> > %{_datadir}/kde4/apps.
> 
> I still think that you would need to modify %files section
> accordingly.  Is a presence of
> /usr/share/kde4/apps/ksmserver/windowmanagers/sawfish.desktop
> really guaranteed in all circumstances?  If /usr/share/kde4 does
> not exist (say CentOS) then why we would want to add it?
> 
> I know that sawfish 1.6.0 does not build on the current CentOS 5
> because corresponding rep-gtk does not compile due to missing
> requirement but "no KDE 4" may be true somewhere else too.
> 
>     Michal

Sawfish on it's own always installs the kde4 sawfish.desktop,
regardless wether it's installed or not. As it might not be on your
system, but on an other one, which your package is installable at.

On the other hand one might ask, why we install the gnome
sawfish.desktop file, regardless wether GNOME is installed or not.

Chris