Re: [PATCH] Re: Bug in Sawfish apps-menu.jl

[Christopher Roy Bratusek <zanghar freenet de>]

Am Sat, 13 Feb 2010 14:50:14 +0900 (JST)
schrieb Teika Kazura <teika lavabit com>:

> Thanks a lot, Matthiew!
> 
> Broken symlink, or unreadable file, is still a problem, but now I can
> manage it. Your patch tells where to touch. (Strictly speaking, broken
> symlink is not our fault, but the packager / distributor's, but not of
> Sawfish users, either, so let's be kind to our beloved users.)
> 
> Chris, after this is fixed, could you release 1.6.2?
> 
> Best regards,
> Teika (Teika kazura)
> 

Hmm, if just commmited a check for readability of files, so -r files don't cause the
issue anymore. Symlinks also shouldn't, as we check wether the file is one (now) and
if so the file is excluded. Currently files with 000 perms are the only way to let
my Sawfish crash here. Though I'm somehow unable to generate a broken link, but
circular linking* is ignored by, so bad should also be.

/usr/bin/x /usr/share/applications/x.desktop both *do not* exist, now do:

ln -sf /usr/bin/x /usr/share/applications/x.desktop
ln -sf /usr/share/applications/x.desktop /usr/bin/x

apps-menu will work, as we use file-symlink-p (and three other -p) to check of the
file for correctness.

Chris