Re: [README] Need two teams for working on sawfish (also for non-developers)

Teika Kazura <teika lavabit com> writes:
> Hi.
> On Tue, 29 Sep 2009 13:08:15 -0500, Jeremy Hankins wrote:
>> Ok, I've pushed the whitespace cleanup changes.
> Well, #| block comments |# are replaced by semicolons. First of all,
> its use policy except the file hearder part wasn't clear, so much
> can't be said. (And not all files used block comments for headers.)
> But (a) we don't ban block comments, right? (b) In fact, #| |#
> except file beginning seems to be left. 

Yeah, I possibly should have checked to make sure no one minded if I
changed that, but it seemed that all the new stuff used ;;.  The problem
was that emacs indentation wasn't working for the block quotes (a bug in
sawfish-mode perhaps?)[1].  I was using a function to auto-indent the
whole buffer to check for things to fix, so I had to go and manually
edit the block quote sections anyway and it was easier to just switch
them than to constantly be going back and fixing the indentation there.

> Block comments indent is supported by emacs sawfish-mode. But probably
> not for ":q" editors? (It's about twice popular then emacs, according
> to a statistics I read.) :p

As it happens, I do use a ":q" editor, but one that lets me use
elisp... viper!  ;)

So I was using sawfish-mode, which did correctly identify those sections
as comments, but this:

#| Foo Bar Baz
   Foo Bar Baz
   Foo Bar Baz

After auto-identation was rendered:

#| Foo Bar Baz
Foo Bar Baz
Foo Bar Baz

Which didn't seem to me to be an improvement.

NOTE: I did a quick git grep for other instances of blockquotes in case
I'd missed something, and all the others I see seem to be indented fine.
But I did notice one thing -- there are a few files that I missed
before.  I've got a local branch that cleans up those as well, and also
changes the block quotes at the beginning.  Shall I go ahead and push
those?  I can leave the block quotes alone if that's preferable.

> On Tue, 29 Sep 2009 20:21:16 +0200, Christopher Roy Bratusek wrote:
>> though a NEWS entry like "major refactoring of the code (removing
>> whitespace, better indention for more readibility)" or something
>> like that, but I would leave that to Teika :)
> Ok, I'll do that for this instance. But *please* make it practice to
> write at least a clue in man/news.texi. I don't keep track of all
> changes, and sometimes I can't tell what's happend.

Sure, I can do that.  Though the heading of the file says it's
user-visible changes, and I don't know that whitespace cleanup qualifies
as user-visible.

[1] The other cases where emacs/sawfish-mode indentation got it 'wrong':

 - let-fluid statements
 - let loop statements
 - long quoted lists, so:

 '(a b c d e
   f g h i j)

 was rendered:

 '(a b c d e
     f g h i

Jeremy Hankins <nowan nowan org>

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]