Re: [ANNOUNCE] sawfish-1.3.5.2

[Harald van Dijk <truedfx gentoo org>]

On Fri, Mar 06, 2009 at 11:11:56PM +0000, Tom Hughes wrote:
> Harald van Dijk wrote:
>> On Thu, Mar 05, 2009 at 08:56:17AM +0100, Christopher Roy Bratusek wrote:
>>
>>> new release of sawfish.
>> It's failing rather horribly. Macros are gone from config.h.in but not
>> from the code, meaning sawfish doesn't actually use Xft/Pango, meaning
>> sawfish crashes at startup complaining about invalid fonts. One
>> particularly important macro is HAVE_X11_XFT_XFT_H; it needs to be
>> defined for src/fonts.c (the only place it's referenced) but it never
>> is.
>
> I had the same problem. It's a combination of two things:
>
>   - Firstly some of the AC_DEFINE calls in configure.in are missing
>     a third argument which means autoheader aborts without updating
>     the config.h.in file.

Thanks for the pointer. I see this was fixed in trunk in revision 4323,
and it wasn't a problem before for the 1.3 branch because config.h.in
hadn't been regenerated.

>   - Secondly autogen.sh runs autoheader before aclocal, which means
>     that it may not see the up to date set of defines that need to be
>     added to config.h.in when it runs.

I don't run autogen.sh, but it's nice to know this anyway.

> If both those things are changed and autogen.sh is rerun then a correct 
> config.h.in will be created.