Re: [Patch] rep-gtk and rep-gtk.pc destination



Am Montag, den 05.01.2009, 18:07 +0100 schrieb Jan Kasprzak:
	Hello,

I am trying to build librep, rep-gtk, and sawfish for Fedora 10. So far
I have found one problem in rep-gtk: it installs its pkgconfig file
to /usr/lib/pkgconfig, instead of whatever is given to ./configure as
--libdir option. This can be a problem on multilib systems (on Fedora,
for example, 32-bit libraries sit in /usr/lib, while 64-bit ones
are in /usr/lib64). I suggest the following patch to Makefile.in.

	The other alternative is to use "pkg-config librep --variable=libdir",
but I think when the ./configure accepts the --libdir argument (and even
mentions it in ./configure --help), it should honor it.

-Yenya

--- rep-gtk-0.18.3/Makefile.in.libdir	2008-08-14 19:05:46.000000000 +0200
+++ rep-gtk-0.18.3/Makefile.in	2009-01-05 17:40:53.000000000 +0100
@@ -50,6 +50,7 @@
 
 DESTDIR=
 installdir=$(repexecdir)
+libdir= libdir@
 
 top_srcdir= top_srcdir@
 top_builddir=.
@@ -105,8 +106,8 @@
 	  printf "\nrep_open_globally=yes\n" >>$(DESTDIR)$(installdir)/$$f; \
 	done
 	$(rep_INSTALL_ALIASES) -c . $(DESTDIR)$(installdir)
-	install -d $(DESTDIR)/@prefix@/lib/pkgconfig/
-	install -m644 rep-gtk.pc $(DESTDIR)/@prefix@/lib/pkgconfig/
+	install -d $(DESTDIR)/$(libdir)/pkgconfig
+	install -m644 rep-gtk.pc $(DESTDIR)/$(libdir)/pkgconfig/
 	install -d $(DESTDIR)/@prefix@/share/doc/rep-gtk- version@/
 	install -m755 examples/* $(DESTDIR)/@prefix@/share/doc/rep-gtk- version@/
 

You're right. The next time I'm on my pc I'll commit patches to all three (librep, rep-gtk and sawfish).

Thanks,
Chris

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]