Tiny cause, Grand Impact. Will commit this now. Thanks a lot Timo. 0.90.2 is ready for release. since 1.3.5.1 has been updated to the autotool changes from librep 0.17.4 most sawfish users will get a functional sawfish-ui without me hurrying in hot-fix releasing 1.3.5.4 or 1.5.1. :D Chris Am Dienstag, den 25.08.2009, 18:52 +0300 schrieb Timo Korvola: > On Monday 24 August 2009 18:12:11 Wang Diancheng wrote: > > It is indeed, following is a simple patch to fix the utf-8 related > > bug. Note that this patch only keep it compatible with utf-8 charset, I > > don't known other charsets' status. > > Your patch seems to assume that all octets from 128 to 255 correspond to > printable characters. That is not true for UTF-8 or any other character > encoding I know of. I think it is better just to make c unsigned char, which > makes the code behave as intended - and documented. > > > I think it is better remove 'Escape > > all control codes' (print-escape value) completely. > > I don't think so. Perhaps print-escape should default to false at least in > the interactive interpreter, but it is useful to be able to set it to true. > Librep has no concept of a character set: strings are just arrays of octets > that in some cases might not correspond to printable text in any encoding. >
Attachment:
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil