Re: Fwd: [Debian Bug#464139: sawfish crash openoffice]



tag 464139 confirmed upstream
thanks

On Tue, Feb 05, 2008 at 05:11:34PM +0100, Janek Kozicki wrote:
> Luis Rodrigo Gallardo Cruz said:     (by the date of Tue, 5 Feb 2008 09:58:08 -0600)
> 
> > Woah!
> > 
> > Reproduced. I just killed my whole session.
> > 
> > It's locale related, with OOo in English nothing happens. With the fr
> > translation it dies immediately. That points to my patch :(
> > 
> > I'll run sawfish+OOo in an Xnest and try to get a backtrace.
> 
> 
> Remember that there is Timo's UTF8 patch waiting in queue. Try it.
> 
>   http://sawfish.wikia.com/wiki/Utf_8_names_fix

The patch solves the crash.

But I'm completely confused. The problem here was that OOo does not
set the NET_ properties, only the WM_ ones. My patch was trying
unconditionaly to convert the strings there from the locale encoding
to UTF-8, causing the crash since they came as ISO-8859-1 but the
locales (all of them, sawfish, the nested x server and OOo) *were*
UTF-8.

Adding to my confusion, the patch solves this by passing the property
to Xutf8TextPropertyToTextList, which correctly decodes it to UTF-8,
despite its name making me think it was supposed to do the oposite or
something.

Whatever.

Given this, I say we should do a new point release with this
patch. I'll test the other patch (Titlebar updates) in a little while,
but it seems to me it should be included, too.

Attachment: signature.asc
Description: Digital signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]