[Rhythmbox-devel] [PATCH] Bring back visibility property to DBus

[Oren Held <oren held org il>]

This should bring resolve the problems:
* "rhythmbox-client --hide" doesn't hide rhythmbox
* "rhythmbox-client" doesn't make sure rhythmbox is visible again

That's kinda reverting commit ef0e07473 from 2006.
---
Additional notes:
0. This problem originates in Debian bug 
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=605438 . The report is 
for 0.12.8, but I reproduced the same with latest git snapshot of rb.

1. Originally 'visibility' dbus property was removed on commit ef0e07473 
due to this dbus bug https://bugs.freedesktop.org//show_bug.cgi?id=7057 
. I *assume* that dbus issue was fixed, both because it's very old, and 
because that it was marked as a dup of another bug (8607) which got 
fixed. But I didn't prove 7057 is no more of an issue.

2. Applying this patch which brings back the dbus property - *does* 
resolve the problem in my case.

3. I've been discussing this bug with Uri Sivan, he claims the 
'rhythmbox-client --hide' works as expected (prior to my patch) on his 
Ubuntu box, even though we used the same git snapshot of rhythmbox. I 
couldn't explain it.

 shell/rb-shell.xml |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/shell/rb-shell.xml b/shell/rb-shell.xml
index 8b6e804..1870b40 100644
--- a/shell/rb-shell.xml
+++ b/shell/rb-shell.xml
@@ -70,9 +70,7 @@
     <signal name="removableMediaScanFinished"/>
     <signal name="databaseLoadComplete"/>
 -    <!-- Until a version of dbus with bug #7057 fixed is widely 
available,
-         this does more harm than good.  -->
-    <!-- <property name="visibility" type="b" access="readwrite"/> -->
+    <property name="visibility" type="b" access="readwrite"/>
    </interface>
 </node>
--
1.7.2.3