[Rhythmbox-devel] [patch] Missing D-BUS signal arguments

[Tim Moloney <t moloney verizon net>]

I'm learning about D-BUS and I'm using Rhythmbox as a D-BUS application.

I noticed that the signal definitions are missing their arguments in the 
D-BUS Introspection Data Format.  I've attached a patch that I believe 
corrects this.

On a related issue, org.gnome.Rhythmbox.Shell.visibilityChanged returns 
false when Rhythmbox is minimized which makes sense.  However, it 
returns true followed immediately by false when Rhythmbox is restore.  I 
don't think that the second (false) signal is correct but perhaps I 
don't correctly understand the functionality.

Tim Moloney

--- rhythmbox-0.9.3.1/shell/rb-shell.xml.orig	2005-08-29 21:40:08.000000000 -0400
+++ rhythmbox-0.9.3.1/shell/rb-shell.xml	2006-04-20 22:18:51.000000000 -0400
@@ -31,7 +31,9 @@
       <arg type="v" name="value"/>
     </method>
 
-    <signal name="visibilityChanged"/>
+    <signal name="visibilityChanged">
+      <arg name="visibility" type="b"/>
+    </signal>
 
   </interface>
 </node>

--- rhythmbox-0.9.3.1/shell/rb-shell-player.xml	2006-01-08 00:26:51.000000000 -0500
+++ rhythmbox-0.9.3.1/shell/rb-shell-player.xml	2006-04-20 22:12:48.000000000 -0400
@@ -64,9 +64,15 @@
     </method>
 
     <!-- <property name="playing" access="readwrite"/> -->
-    <signal name="playingChanged"/>
-    <signal name="playingUriChanged"/>
-    <signal name="elapsedChanged"/>
+    <signal name="playingChanged">
+      <arg name="playing" type="b"/>
+    </signal>
+    <signal name="playingUriChanged">
+      <arg name="playingUri" type="s"/>
+    </signal>
+    <signal name="elapsedChanged">
+      <arg name="elapsed" type="u"/>
+    </signal>
 
   </interface>
 </node>