Re: [Rhythmbox-devel] Last.fm Integration Patch #2

[Ruben Vermeersch <ruben Lambda1 be>]

On Thu, 2005-09-15 at 17:03 -0500, James Cotton wrote:
> When I applied both patches I get this error:
> 
> if gcc -DHAVE_CONFIG_H -I. -I. -I.. -DGNOMELOCALEDIR=
> \""/usr/share/locale"\" -DG _LOG_DOMAIN=\"Rhythmbox\" -I.. -I../lib
> -I../metadata -I../player -I../rhythmdb -I../widgets -I../sources
> -I../iradio -I../remote -I../remote -DPIXMAP_DIR=\""/u
> sr/share/pixmaps"\" -DSHARE_DIR=\"/usr/share/rhythmbox\" -DDATADIR=
> \""/usr/share "\"   -DORBIT2=1 -pthread -I/usr/include/gtk-2.0
> -I/usr/lib/gtk-2.0/include -I/u sr/include/atk-1.0
> -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/ glib-2.0
> -I/usr/lib/glib-2.0/include -I/usr/include/libgnomeui-2.0
> -I/usr/includ e/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0
> -I/usr/include/libart-2.0 -I/us r/include/gconf/2
> -I/usr/include/libbonoboui-2.0 -I/usr/include/gnome-vfs-2.0
> -I /usr/lib/gnome-vfs-2.0/include -I/usr/include/gnome-keyring-1
> -I/usr/include/orb it-2.0 -I/usr/include/libbonobo-2.0
> -I/usr/include/bonobo-activation-2.0 -I/usr/ include/freetype2
> -I/usr/include/libxml2 -I/usr/include/libglade-2.0 -I/usr/incl
> ude/gnome-vfs-module-2.0   -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
> -pthread - DORBIT2=1 -I/usr/include/gstreamer-0.8
> -I/usr/include/glib-2.0 -I/usr/lib/glib-2 .0/include
> -I/usr/include/libxml2 -I/usr/include/gconf/2 -I/usr/include/orbit-2.
> 0   -pthread -DORBIT2=1 -I/usr/include/totem/1/plparser
> -I/usr/include/gtk-2.0 - I/usr/include/libxml2
> -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/incl ude
> -I/usr/include/gnome-vfs-module-2.0 -I/usr/lib/gtk-2.0/include
> -I/usr/includ e/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0
> -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
> -I/usr/include/bonobo-activation-2.0 -I/usr/include/ libbonobo-2.0
> -I/usr/include/gconf/2 -I/usr/include/orbit-2.0   -I/usr/include/d
> bus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0
> -I/usr/lib/glib-2.0/ include   -DDBUS_API_SUBJECT_TO_CHANGE
> -D_XOPEN_SOURCE -D_BSD_SOURCE -I../remote /bonobo -I../remote/dbus
> -I../daapsharing -I/usr/include/libsoup-2.2 -I/usr/incl ude/libxml2
> -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include      -g -O2 -Wco
> mment -Wformat -Wnonnull -Wimplicit-int -Wimplicit -Wmain
> -Wmissing-braces -Wpar entheses -Wsequence-point -Wreturn-type
> -Wswitch -Wtrigraphs -Wunused-function - Wunused-label -Wunused-value
> -Wchar-subscripts -Wmissing-declarations -Wmissing- prototypes
> -Wnested-externs -Wpointer-arith -Wcast-align -Wall -Werror -std=gnu8
> 9 -MT rb-audioscrobbler.o -MD -MP -MF ".deps/rb-audioscrobbler.Tpo" \
>   -c -o rb-audioscrobbler.o `test -f 'rb-audioscrobbler.c' || echo
> './'`rb-audio scrobbler.c; \
> then mv -f ".deps/rb-audioscrobbler.Tpo" ".deps/rb-audioscrobbler.Po";
> \
> else rm -f ".deps/rb-audioscrobbler.Tpo"; exit 1; \
> fi
> rb-audioscrobbler.c:1117: error: conflicting types for
> 'rb_audioscrobbler_load_q ueue'
> rb-audioscrobbler.c:126: error: previous declaration of
> 'rb_audioscrobbler_load_ queue' was here
> rb-audioscrobbler.c:1117: error: conflicting types for
> 'rb_audioscrobbler_load_q ueue'
> rb-audioscrobbler.c:126: error: previous declaration of
> 'rb_audioscrobbler_load_ queue' was here
> rb-audioscrobbler.c:126: warning: 'rb_audioscrobbler_load_queue'
> declared `stati c' but never defined
> rb-audioscrobbler.c:1117: warning: 'rb_audioscrobbler_load_queue'
> defined but no t used
> make[3]: *** [rb-audioscrobbler.o] Error 1
> make[3]: Leaving directory `/home/jcotton/source/rhythmbox/shell'
> make[2]: *** [all] Error 2
> make[2]: Leaving directory `/home/jcotton/source/rhythmbox/shell'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/home/jcotton/source/rhythmbox'
> make: *** [all] Error 2
> 
> It compiled fine without --enable-audioscrobbler
> 
> let me know if you want to see any of the file contents.

Hi James,

that seems to be an error in the GNOME-VFS code (the second patch, by
James Livingston), I'll have a look at it this afternoon, and post a
merged (and somewhat improved) patch. For now, using only the first
patch should work though, haven't tested the combined version yet.

Regards,
Ruben


--
Ruben Vermeersch (rubenv)
http://www.Lambda1.be/