Re: [Rhythmbox-devel] patch for search entry

On Sat, 2005-09-10 at 17:18 -0400, Charles Schmidt wrote:
> Attached is a patch against CVS for the search entry that does two
> things:
> * Adds an icon that when pressed drops down a menu, allowing you to
> select what to search (All, Artists, Albums, Songs).  The code that
> would make the selection actually work has not been written yet, I
> thought it better to get comments on this before I spend time doing
> that.

Banshee does something like this, and it has a separator between "All"
and the other options; it also has a triangle on the icon, which makes
it more discoverable. I'd also probably change "Songs" to "Song Titles"
and add Genres to the list. 

> * Adds and icon that when pressed clears the search entry ("clear
> button")

Looks good.

The icons should probably have separate tooltips, indicating what they
do. Another issue is that you can't select them (particularly the menu
icon) by keyboard navigation, which has accessibility problems.

> This is a request for comments & suggestions regarding this patch.  I
> think these would be nice features, but I understand there has been some
> debate in the past about a clear button, perhaps this new way (as
> opposed to a large GtkButton) sovles it?

I don't really have an optinion one way or the other about whether it's
included, but using a configure option (as was recently posted to the
list) isn't that way to go - we should either have it, or not.


James "Doc" Livingston
2*3*3*37 : The Prime Factorization of The Beast

Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]