On Sun, 2005-11-06 at 09:13 +0100, Artem Baguinski wrote: > for one it would have been nice if the artists / albums "emptied" by > filtering would disappear, so that if I enter "klezmer" in a search > entry I'd endup with klezmer artists and klezmer albums in the artists > and albums lists. Doing that requires moving one case label about 20 line up (patch attached). However it highlights the problem that changing a browser resets the browsers "after" it, e.g. changing from Artist A to All Artists will reset the album browse - so typing in the search box resets all browsers. Fixing that shouldn't be too hard (but not trivial) and I think it's mostly a matter of no-one getting around to it. > On 06/11/05, James Livingston <jrl ids org au> wrote: > > Having the browsers reset when you start typing into the search box may > > also be confusing to users, because typing in an entry usually doesn't > > cause other widgets to change state. > > That's the UI design flaw then. If to initiate search user was > required to do something implying browser reset - like press a button > or switch a tab there would be no problem. I'm not sure how could it > be done better though. Requiring the user to make an effort to switch from using the browsers to using the search box (or vice versa) means that most people will stick to just using one. Although using both at once is rare, I don't think it would be that uncommon for people to sometimes use one, and sometimes use the other. Cheers, James "Doc" Livingston -- Brown's Theorem (Physics III student, USyd): "The only thing that behaves like a billiard ball, is a billiard ball"
Index: sources/rb-library-source.c
===================================================================
RCS file: /cvs/gnome/rhythmbox/sources/rb-library-source.c,v
retrieving revision 1.122
diff -u -u -r1.122 rb-library-source.c
--- sources/rb-library-source.c 5 Nov 2005 05:03:18 -0000 1.122
+++ sources/rb-library-source.c 6 Nov 2005 08:48:00 -0000
@@ -1564,6 +1564,7 @@
}
switch (qtype) {
case RB_LIBRARY_QUERY_TYPE_ALL:
+ case RB_LIBRARY_QUERY_TYPE_SEARCH:
rb_debug ("resetting genres view");
g_list_foreach (source->priv->selected_genres,
(GFunc) g_free, NULL);
@@ -1597,7 +1598,6 @@
g_object_set (G_OBJECT (album_model), "query-model",
query_model, NULL);
case RB_LIBRARY_QUERY_TYPE_ALBUM:
- case RB_LIBRARY_QUERY_TYPE_SEARCH:
break;
}
}
Attachment:
signature.asc
Description: This is a digitally signed message part