Re: [Rhythmbox-devel] Rework of column resizing

[Jonathan Matthew <jonathan kaolin hn org>]

On Thu, May 05, 2005 at 04:11:06AM +0200, Oliver Lemke wrote:
> On Thu, 2005-05-05 at 11:52 +1000, Jonathan Matthew wrote:
> > On Thu, May 05, 2005 at 03:43:40AM +0200, Oliver Lemke wrote:
> > > Hi all,
> > > 
> > > I've tried to make the column resizing behave similar to evolution's
> > > mail list view. The current implementation has still some glitches when
> > > adding / removing columns from the preferences but it is usable and
> > > (hopefully) better than before.
> > 
> > Heh.  I'm halfway through my own attempt at this.  I'm not yet at the
> > point where I'm even considering adding/removing columns, so you're
> > obviously doing better than me. 
> 
> I'm curious, what is your approach? Did you replace the treeview widget
> with your own one? I just hacked the existing
> gtk_tree_view_size_allocate_columns function to make it suck less. But
> maybe this will turn out to have unforeseen side effects. We'll see. ;-)

My approach was to throw away the existing
gtk_tree_view_size_allocate_columns and reimplement it based on code
from e-table-header.c.  The differences between ETable and GtkTreeView
are pretty significant, so it was probably doomed anyway.


> > I'll take a closer look tonight, but
> > I'm guessing I should just scrap my version and work on something else
> > instead.
> 
> Yeah, before wiping your work, take a look at mine, not that it turns
> out that I blew it....

I'm trying yours at the moment (not that it's tonight yet; I'm just
bored), and, well, it actually works; mine isn't even close.  Once you
get the problems with adding/removing columns sorted out, it'll be a
huge improvement over the current code.

> >  Maybe getting history working in the queue..
> 
> Just to make sure that we're not "wasting" our time on the same stuff
> again: Next point on my list is getting the artist displayed below the
> album names in the browser.....

OK.  Aside from queue history, I'm probably going to look at the iradio
entry view/browser, which has some weird problems.  There are some other
iradio bits and pieces too, but I forget what they are right now.

-jonathan