Re: [Rhythmbox-devel] Build fixes and error dialog prevention

[Matt Jones <mattharrison sbcglobal net>]

Hi -

My build breaks with the new inline changes - i think its something to
do with inline support in my compiler (gcc 3.4). Why does glib 2.6 need
the changes? If i roll them back (just on rb-refstring.c), it seems to
compile fine.

All the errors are in regards to missing symbols with the inline
functions in rb-refstrings.h. So my guess is the functions are declared
extern (rather then inline, as G_IMPLEMENT_INLINES is defined), which
somehow breaks everything.

Thanks,

--Matt Jones

On Sun, 2005-01-09 at 12:53 -0500, William Jon McCann wrote:
> Christophe Fergeau wrote:
> > On ven, 2005-01-07 at 11:24 -0500, William Jon McCann wrote:
> > 
> >>Hi,
> >>
> >>In my arch mirror (http://acs.pha.jhu.edu/~mccannwj/archive/) I have 
> >>patches that will:
> >>
> >>- Fix the build with the new nautilus-cd-burner 2.9 API
> >>- Fix the build with rb-refstrings inline stuff for glib 2.6
> >>- Add the new functionality to prevent error message popups and add a 
> >>"!" icon.
> >>
> >>The error message part has not changed since Christophe reviewed it.  Is 
> >>it ok to commit these to the mainline?
> > 
> > 
> > I have a -playbin branch in my repository where I merged your stuff and
> > did some other (unrelated actually) changes (port to gstreamer playbin
> > element for the playing part, removal of the xine backend ,...), I was
> > planning to merge this branch to mainline soon. I guess you can merge
> > all that stuff to mainline, I'll handle the merge of the remaining parts
> > in my branch on my own, this shouldn't be too difficult.
> 
> Ok, I've committed my changes.  Thanks Christophe.  I hope this doesn't
> cause you trouble.
> 
> Jon
> _______________________________________________
> rhythmbox-devel mailing list
> rhythmbox-devel gnome org
> http://mail.gnome.org/mailman/listinfo/rhythmbox-devel