Re: [Rhythmbox-devel] Build fixes and error dialog prevention



Christophe Fergeau wrote:
On ven, 2005-01-07 at 11:24 -0500, William Jon McCann wrote:

Hi,

In my arch mirror (http://acs.pha.jhu.edu/~mccannwj/archive/) I have patches that will:

- Fix the build with the new nautilus-cd-burner 2.9 API
- Fix the build with rb-refstrings inline stuff for glib 2.6
- Add the new functionality to prevent error message popups and add a "!" icon.


The error message part has not changed since Christophe reviewed it. Is it ok to commit these to the mainline?


I have a -playbin branch in my repository where I merged your stuff and
did some other (unrelated actually) changes (port to gstreamer playbin
element for the playing part, removal of the xine backend ,...), I was
planning to merge this branch to mainline soon. I guess you can merge
all that stuff to mainline, I'll handle the merge of the remaining parts
in my branch on my own, this shouldn't be too difficult.

Ok, I've committed my changes. Thanks Christophe. I hope this doesn't cause you trouble.


Jon

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]