Christophe, On Thu, 2005-04-14 at 09:20 +0200, Christophe Fergeau wrote: > Hi, > > Le jeudi 14 avril 2005 Ã 01:57 -0400, Jon Oberheide a Ãcrit : > > Issue #1 > > ======== > > rhythmdb.c:2606: warning: implicit declaration of function `ngettext' > > rhythmdb.c:2606: warning: nested extern declaration of `ngettext' > > > > Fixed by attached rhythmbox-libintl-fix.patch > > Including gi18n.h instead of libintl.h would be better I think (if that > helps with compilation obviously ;) Sounds good. I see that gi18n.h also includes libintl.h so that should fix the problem nicely. > > Issue #2 > > ======== > > rb-remote-bonobo.c:547: warning: ISO C90 forbids mixed declarations and > > code > > > > The offending line: > > guint prop_id = bonobo->priv->next_property++; > > > > There is probably something like > mytype var; > somecode(); > myothertype var2; > in this file. > > Changing it to > mytype var; > myothertype var2; > somecode(); > > should fix your compilation problem. Wow, yeah, I completely glazed over that error message for some reason. > > Some of these may possibly be Gentoo specific as I haven't seen any one > > else complaining about them, but proper fixes wouldn't negatively affect > > other distros. > > What compiler are you using? GCC 3.4.3. I didn't realize it was so pedantic about the variable declaration these days but I guess it's a good warning to have for compatibility-sake with older compilers. Attached is an updated patch for both of the above issues. It was against Jonathan's rhythmbox--remote--0.9 but should probably apply to mainline as well if necessary. Regards, Jon Oberheide -- Jon Oberheide <jon oberheide org> GnuPG Key: 1024D/F47C17FE Fingerprint: B716 DA66 8173 6EDD 28F6 F184 5842 1C89 F47C 17FE
diff -ur ../old/rhythmbox--remote--0.9--patch-9/remote/bonobo/rb-remote-bonobo.c ./remote/bonobo/rb-remote-bonobo.c
--- ../old/rhythmbox--remote--0.9--patch-9/remote/bonobo/rb-remote-bonobo.c 2005-04-14 04:33:40.000000000 -0400
+++ ./remote/bonobo/rb-remote-bonobo.c 2005-04-14 04:26:49.000000000 -0400
@@ -542,10 +542,13 @@
const gchar *property,
const gchar *description)
{
+ guint prop_id;
+ GParamSpec *param;
+
g_assert (bonobo->priv->next_property < G_N_ELEMENTS (bonobo->priv->property_spec));
- guint prop_id = bonobo->priv->next_property++;
- GParamSpec *param = rb_remote_proxy_find_player_property (bonobo->priv->proxy,
+ prop_id = bonobo->priv->next_property++;
+ param = rb_remote_proxy_find_player_property (bonobo->priv->proxy,
property);
bonobo->priv->property_spec[prop_id] = param;
diff -ur ../old/rhythmbox--remote--0.9--patch-9/rhythmdb/rhythmdb.c ./rhythmdb/rhythmdb.c
--- ../old/rhythmbox--remote--0.9--patch-9/rhythmdb/rhythmdb.c 2005-04-14 04:33:29.000000000 -0400
+++ ./rhythmdb/rhythmdb.c 2005-04-14 04:27:49.000000000 -0400
@@ -31,6 +31,7 @@
#include "rhythmdb-property-model.h"
#include "rb-metadata.h"
#include <string.h>
+#include <glib/gi18n.h>
#include <gobject/gvaluecollector.h>
#include <glib/gatomic.h>
#include <gconf/gconf-client.h>
diff -ur ../old/rhythmbox--remote--0.9--patch-9/sources/rb-iradio-source.c ./sources/rb-iradio-source.c
--- ../old/rhythmbox--remote--0.9--patch-9/sources/rb-iradio-source.c 2005-04-14 04:33:29.000000000 -0400
+++ ./sources/rb-iradio-source.c 2005-04-14 04:28:41.000000000 -0400
@@ -20,6 +20,7 @@
*/
#include <config.h>
+#include <glib/gi18n.h>
#include <gtk/gtk.h>
#include <glade/glade.h>
#include <libgnome/gnome-i18n.h>
Attachment:
signature.asc
Description: This is a digitally signed message part