Greetings, These fixes/problems are on a Gentoo ~x86 box and are against the latest rhythmbox--remote--0.9 tree. I haven't been able to compile this tree for a while and finally have some time to go through it. Some of these may apply to mainline as well but I haven't tested it yet. Issue #1 ======== rhythmdb.c:2606: warning: implicit declaration of function `ngettext' rhythmdb.c:2606: warning: nested extern declaration of `ngettext' Fixed by attached rhythmbox-libintl-fix.patch Issue #2 ======== rb-remote-bonobo.c:547: warning: ISO C90 forbids mixed declarations and code The offending line: guint prop_id = bonobo->priv->next_property++; After looking at remote/bonobo/rb-remote-bonobo.h, it seems that the RBRemoteBonoboPrivate struct doesn't even have any members defined in it. Is there some bonobo magic here that I'm missing? The only way to work around this is to ignore compiler warnings. Issue #3 ======== During "make install": LC_ALL=C ../../intltool-merge -o -u -c ../../po/.intltool-merge-cache ../../po Rhythmbox_Nautilus_Context_Menu.server.in Rhythmbox_Nautilus_Context_Menu.server /bin/sh ../../mkinstalldirs /usr/local/lib/bonobo/servers /usr/bin/install -c -m 644 ./Rhythmbox_Nautilus_Context_Menu.server /usr/local/lib/bonobo/servers/Rhythmbox_Nautilus_Context_Menu.server /usr/bin/install: cannot stat `./Rhythmbox_Nautilus_Context_Menu.server': No such file or directory It appears that the intltool-merge command is not actually creating Rhythmbox_Nautilus_Context_Menu.server in the remote/bonobo/ directory for whatever reason. Issue #X ======== I may be missing a lot more warnings that shouldn't be ignored by disabling warnings but I can't get past #2 to find out... Some of these may possibly be Gentoo specific as I haven't seen any one else complaining about them, but proper fixes wouldn't negatively affect other distros. Comments definitely appreciated. Regards, Jon Oberheide -- Jon Oberheide <jon oberheide org> GnuPG Key: 1024D/F47C17FE Fingerprint: B716 DA66 8173 6EDD 28F6 F184 5842 1C89 F47C 17FE
diff -ur ../new/rhythmbox--remote--0.9--patch-9/rhythmdb/rhythmdb.c ./rhythmdb/rhythmdb.c --- ../new/rhythmbox--remote--0.9--patch-9/rhythmdb/rhythmdb.c 2005-04-14 01:20:57.000000000 -0400 +++ ./rhythmdb/rhythmdb.c 2005-04-14 01:16:38.000000000 -0400 @@ -20,6 +20,7 @@ */ #include <config.h> +#include <libintl.h> #define G_IMPLEMENT_INLINES 1 #define __RHYTHMDB_C__ diff -ur ../new/rhythmbox--remote--0.9--patch-9/sources/rb-iradio-source.c ./sources/rb-iradio-source.c --- ../new/rhythmbox--remote--0.9--patch-9/sources/rb-iradio-source.c 2005-04-14 01:20:57.000000000 -0400 +++ ./sources/rb-iradio-source.c 2005-04-14 01:18:07.000000000 -0400 @@ -20,6 +20,7 @@ */ #include <config.h> +#include <libintl.h> #include <gtk/gtk.h> #include <glade/glade.h> #include <libgnome/gnome-i18n.h>
Attachment:
signature.asc
Description: This is a digitally signed message part