On Tue, 2004-03-09 at 14:45, Colin Walters wrote: > > With these changes, I believe auto rating Just Works. > > > > There was some talk of maybe setting the default for auto-rating to off > > and having some UI for toggling that gconf pref in the preference > > dialog. I argue that that would be unnecessary, merely because I think > > it is a small use-case we would be going for there. > > > > The only use-case in which we would want easy, in-your-face toggling of > > global auto-rating is if the user has a pre-existing database of > > hand-rated songs that they don't want being toyed with. Because, if a > > new user just wants hand-rated songs, auto-rating will be turned off for > > each song individually. So, is this segment large enough that we want > > to expose UI for the gconf setting? > > Well, one thing you could do (I'm not sure if you've already done this) > is to allow the checkbox to work even when multiple songs are selected. > Most of the code infrastructure for that is already there from the tag > editing work. That way, if the user didn't want their songs > automatically rated at all, they could just Edit->Select All, then > select Properties, and uncheck the autorating checkbox. (The checkbox > state when multiple songs were selected would default to the global > autorating state). > > This would actually give people even more power than the global checkbox > - you could pretty easily decide to autorate some of your music, but not > all of it. We'd have to document this of course, since it would be > slightly obscure. OK, I looked into this and the song-info dialog is woefully unprepared for multiple selections. It seems that when more than one entry is selected, there is a GList in the SongInfo struct that represents all the entries, which is all well and good. However, the code never does anything with the list. It just displays empty widgets. Is someone else working to make the multi-song-info dialog work better? If not, I can go about and try to change this, but I'm not sure how to best display inconsistent data like the song titles. Only fill out the parts that are the same? -mt
This is a digitally signed message part